[osg-submissions] osg/Notify.cpp: add level prefix to messages for easy sorting/culling of messages

[Robert Osfield]

Hi Bob,

I've just reviewed your changes and understand the intent, but don't
agree with the actual implement so I'm rejecting the submission for
now.

The reason is that they way you have implemented isn't optional, and
the implementation assumes that the entry will be on a new line.  i.e.

 osg::notify(osg::NOTICE)<<"Hello";
 osg::notify(osg::NOTICE)<<" World"<<std::endl;

Would result in:

 "notice     : Hellonotice     :World"

Making the prefix optional is certainly doable, but I don't know of a
simple answer the above issue.


Robert.

On Sat, Apr 26, 2008 at 4:08 PM, Bob Kuehne <rpk at blue-newt.com> wrote:
> the attached change does two things to the osg notification code:
>
>  1) cleans up the logic involved in returning the ostream in osg::notify()
>  2) adds a prefix to osg::notify() to print the level of the message, along
>    with whatever user output follows
>
>  change 2 depends upon change 1.
>
>  bob
>
>
>
> _______________________________________________
>  osg-submissions mailing list
>  osg-submissions at lists.openscenegraph.org
>
> http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
>
>