[osg-submissions] API configurations in a seperate Config include file

[Robert Osfield]

Hi Mathias,

I haven't done the background work on CMake/Config files so I have to
defer to your experience with this.  In terms of what makes sense as a
layman, to me having headers lists as headers along with the rest of
the headers seems logical.  Having extra headers "automagically" be
added to the header list is less intuitive.

As a test I've put a # in front of the INSTALL_FILES directive for the
two Config files, this works fine, removing the double install.  I've
now checked in this tweak.

The open question for me, is does the config setup code automatically
put the headers into the OpenThreads_PUBLIC_HEADERS and
LIB_PUBLIC_HEADERS?  If it does then my own additions would break
this, but I kinda doubt this is happening as otherwise the
INSTALL_FILES directive you added wouldn't have been required.

Robert.

On Mon, Jun 23, 2008 at 10:34 AM, Mathias Fröhlich
<M.Froehlich at science-computing.de> wrote:
>
> Hi Robert,
>
> On Monday 23 June 2008 10:33, Robert Osfield wrote:
>> Hi Mathias,
>>
>> On Mon, Jun 23, 2008 at 9:18 AM, Mathias Fröhlich
>>
>> <M.Froehlich at science-computing.de> wrote:
>> > As far as I can tell, the 'clean' solution is to not include the config
>> > headers in the headers list.
>> > They get installed by the
>> > INSTALL_FILES
>> > directive.
>>
>> Clean? I'm not sure what you think isn't clean about listing the files
>> in the header list.
> I do not rememeber where I found this in the docs, but I did this like
> documented by the cmake guys.
> No reference at hands in this minute ...
>
>> As far as I'm aware some compilers/IDE's require all the headers to be
>> list.
> I do not know the ide stuff here. But when the cmake guys document that in
> this way, I expect that to work also with those ide's cmake supports ...
>
>> If they are listed how to do they end up in the INSTALL_FILES list?
> Ask the cmake guys. What I provided appears to be the documented way to cope
> with this kind of configuration files.
>
>> > This is what I have posted and tested with various UNIX builds here.
>>
>> And what I've amended has been tested across platforms and reports so
>> far is that it's sound.
>>
>> Could you please test what is in SVN and if there is a problem then
>> highlight this, suggests alternatives.
> It appears to work at least on my workstation.
>
> Given your previous requirement with duplicated include directories ...
> You might notice that when the Config files are listed in the header list, it
> is installed twice by the make install target:
>
> [..]
> -- Install configuration: ""
> -- Installing: /tmp/xxx/include/osg/Config
> -- Installing: /tmp/xxx/include/OpenThreads/Config
> [..]
> -- Installing: /tmp/xxx/include/OpenThreads/Version
> -- Up-to-date: /tmp/xxx/include/OpenThreads/Config
> -- Installing: /tmp/xxx/lib64/libosg.so.2.5.3
> [..]
> -- Installing: /tmp/xxx/include/OpenThreads/Version
> -- Up-to-date: /tmp/xxx/include/osg/Config
> -- Installing: /tmp/xxx/lib64/libosgDB.so.2.5.3
> [..]
>
> Whereas the Up-To-date lines do not happen with what I provided.
> You may alternatively remove the INSTALL_FILES directive from my changes to
> get rid of that ...
>
> I am fine with all that works - just want to share what I was digging out when
> doing that ...
>
> GReetings
>
> Mathias
>
> --
> Dr. Mathias Fröhlich, science + computing ag, Software Solutions
> Hagellocher Weg 71-75, D-72070 Tuebingen, Germany
> Phone: +49 7071 9457-268, Fax: +49 7071 9457-511
> --
> Vorstand/Board of Management:
> Dr. Bernd Finkbeiner, Dr. Florian Geyer,
> Dr. Roland Niemeier, Dr. Arno Steitz, Dr. Ingrid Zech
> Vorsitzender des Aufsichtsrats/
> Chairman of the Supervisory Board:
> Prof. Dr. Hanns Ruder
> Sitz/Registered Office: Tuebingen
> Registergericht/Registration Court: Stuttgart
> Registernummer/Commercial Register No.: HRB 382196
>
>
> _______________________________________________
> osg-submissions mailing list
> osg-submissions at lists.openscenegraph.org
> http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
>