[osg-submissions] ImageStream and xine plugin

[Robert Osfield]

Hi Uwe,

Just removing the env var wouldn't solve the extra code complexity,
rather one needs to refactor the classes a bit to make things more
maintainable.  I can tackle this work, but not right away.

Robert

On Fri, Jun 6, 2008 at 9:08 PM, Uwe Woessner <woessner at hlrs.de> wrote:
> Hello Robert,
>
> I could throw out the env var and resubmit.
> This would satisfy your last statement of consistency and it would keep the
> code simple.
> I don´t think that a xine object pool would help many users. I was more
> concerned about memory consumption processing overhead during runtime of the
> movies. Rather than startup overhead. That´s why I thought having the option
> of a single xine would be nice. But if you don´t think its necessary, I
> won´t convert the env checking to it to ReaderWriter::Options.
>
>  Uwe
> Robert Osfield schrieb:
>>
>> Hi Uwe,
>>
>> I've just done a review of your changes, and unfortunately they
>> complicated things alot more than I'd like.
>>
>> It seem like to me we need to have multiple xine objects, one per
>> XineImageStream, rather than try to enable a single global xine object
>> when the multiple xine is not enabled.  Perhaps for efficiency sake we
>> could share xine objects between subsequent XineImageStream i.e. if
>> one deallocates it could return its handle to ReaderWriterXine to pass
>> on the the new attempt to create an XineImageStream.  This would leave
>> a pool xine handles in ReaderWriterXine that it can clean up on exit -
>> this should work fine though.
>>
>> I would dispatch with all the env var checking though, this is just
>> added complexity both in the implementation and in the usage of videos
>> - i.e. under Linux we'd need to know about this special case and set
>> the env var/ReaderWriter::Options to enable independent pausing.  This
>> is so obscure that it almost certainly will catch people out.  I think
>> it's best to just go for making functionality as consistent across all
>> platforms out of the bag, even if this means a little extra overhead.
>>
>> Robert.
>>
>> On Fri, Jun 6, 2008 at 10:12 AM, Uwe Woessner <woessner at hlrs.de> wrote:
>>>
>>> Hello,
>>>
>>> We wanted to play multiple movies. everyting works fine so far but as
>>> soon
>>> as you want to stop one movie, all other movies stop as well.
>>> The only work around we found is to use an individual xine instance for
>>> each
>>> movie stream.
>>> This is not desirable from a resource point of view if you don´t want to
>>> stop individual streams, thus we check for an environment variable and
>>> only
>>> use multiple xines if this is set.
>>> Is there a better way to pass parameters to an osgDB plugin?
>>> If not I would suggest to include the following changes.
>>> See attached tar archive for the files.
>>>
>>> I would like to suggest the following changes:
>>> OpenSceneGraph/include/osg/ImageStream
>>> add STOPPED State
>>> OpenSceneGraph/src/osgPlugins/xine/video_out_rgb.c
>>> initialization of frame->chunk[0]
>>> OpenSceneGraph/src/osgPlugins/xine/ReaderWriterXine.cpp
>>> support for multiple xine instances
>>>
>>> Regards,
>>>  Uwe
>>>
>>>
>>> --
>>>
>>>          \\\|/// *HLRS, High Performance Computing Center Stuttgart*
>>>  _I_       ( o o )                *Visualization/VR*             _I_
>>> (_ at _)--oo0O--(_)--O0oo------------------------------------------(_ at _)
>>>  | |    Uwe Woessner             woessner at hlrs.de                | |
>>>  | |       .ooo0       http://www.hlrs.de/people/woessner/       | |
>>>  |_|       (   )  Oooo. Phone: +49-711-6856-5790 or ...-5970     |_|
>>> (_ at _)-------\ (---(   )-----------------------------------------(_ at _)
>>>  I          \_)   ) /                                            I
>>>                 (_/
>>>
>>> _______________________________________________
>>> osg-submissions mailing list
>>> osg-submissions at lists.openscenegraph.org
>>>
>>> http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
>>>
>>>
>> _______________________________________________
>> osg-submissions mailing list
>> osg-submissions at lists.openscenegraph.org
>>
>> http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
>>
>
>
> --
>
>           \\\|/// *HLRS, High Performance Computing Center Stuttgart*
>  _I_       ( o o )                *Visualization/VR*             _I_
> (_ at _)--oo0O--(_)--O0oo------------------------------------------(_ at _)
>  | |    Uwe Woessner             woessner at hlrs.de                | |
>  | |       .ooo0       http://www.hlrs.de/people/woessner/       | |
>  |_|       (   )  Oooo. Phone: +49-711-6856-5790 or ...-5970     |_|
> (_ at _)-------\ (---(   )-----------------------------------------(_ at _)
>  I          \_)   ) /                                            I
>                  (_/
> _______________________________________________
> osg-submissions mailing list
> osg-submissions at lists.openscenegraph.org
> http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
>