[osg-submissions] FrameBuffer AntiAliasing with OSG 2.5

[paul1492 at yahoo.com]

I have no problem with the changes, other than the fact that I couldn't get it to work. :-). 
I have a Quadro FX 5600 and was using 16 samples and 4 color samples (which should be supported by my hardware).  I am getting:
Warning: detected OpenGL error 'invalid value' after RenderBin::draw(,)
RenderStage::drawInner(,) FBO status= 0x8cd5

and the image is garbage.. I don't know what the problem is here...

IIn addition,  also get these warnings when I compile the code:
OpenSceneGraph/src/osgUtil/RenderStage.cpp:858: warning: argument
   passing to `int' from `double'
OpenSceneGraph/src/osgUtil/RenderStage.cpp:858: warning: argument
    to `int' from `double'
OpenSceneGraph/src/osgUtil/RenderStage.cpp:858: warning: argument
   passing to `int' from `double'
OpenSceneGraph/src/osgUtil/RenderStage.cpp:858: warning: argument
    to `int' from `double'
OpenSceneGraph/src/osgUtil/RenderStage.cpp:858: warning: argument
   passing to `int' from `double'
OpenSceneGraph/src/osgUtil/RenderStage.cpp:858: warning: argument
    to `int' from `double'
OpenSceneGraph/src/osgUtil/RenderStage.cpp:858: warning: argument
   passing to `int' from `double'
OpenSceneGraph/src/osgUtil/RenderStage.cpp:858: warning: argument
    to `int' from `double'

I believe the values returned by the viewport size need to be cast to ints when passed to glBlitFramebufferEXT as I did in my code.
I'm also not sure what the purpose is of RenderStage::setResolveFramebufferObject(). Nor am I sure what the advantage is of having the samples and color samples passed to the Camera object directly rather than passing then through the attachment call.

----- Original Message ----
From: Robert Osfield <robert.osfield at gmail.com>
To: OpenSceneGraph Submissions <osg-submissions at lists.openscenegraph.org>
Sent: Tuesday, June 3, 2008 8:10:18 AM
Subject: Re: [osg-submissions] FrameBuffer AntiAliasing with OSG 2.5

Hi Paul and Michael,

I was just about to review Paul's changes when Michael's come along... :-)

Paul could you review Michael's changes to see if you are happy with
his changes, if you are happy then I'll just go ahead to Michael's
version, otherwise I'll probably have to review both sets just to make
sure that nothing has slipped through the net on either
implementation.

Robert.

On Mon, Jun 2, 2008 at 1:41 PM,  <paul1492 at yahoo.com> wrote:
> I've attempted to add FrameBuffer AntiAliasing to OSG... I did this before with OSG 1.2 and now my company has found the money to pay me to look into adding it to the latest OSG.
>
> However, since I do not have access to SVN (not approved use by my employer :-(), I've made the required changes to OSG 2.5... I don't think much has changed in this area since then...
>
> Like last time, I've attached the NVIDIA test program "simple_framebuffer_object.cpp".
> I've done my best to support a "fallback" implementation if the hardware doesn't support it...
> To support frame buffer AA, I've extended the camera->attach() function to support an additional (optional) 2 arguments. They are:  Coverage AA Samples and Depth AA Samples.
> Here is how I call it:
>    camera->attach(osg::CameraNode::COLOR_BUFFER, texture,
>                              0, 0, false,
>                              mCoverageAAMode, mDepthAAMode);
>
> Feel free to make any changes.
> Paul Palumbo
>
>
>
>
> _______________________________________________
> osg-submissions mailing list
> osg-submissions at lists.openscenegraph.org
> http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
>
>
_______________________________________________
osg-submissions mailing list
osg-submissions at lists.openscenegraph.org
http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org