[osg-submissions] Use atomic reference counts
Robert Osfield
robert.osfield at gmail.com
Tue Jun 3 05:56:55 PDT 2008
Hi Mathias,
Looking at include/OpenThreads/Atomic
There is:
#if defined(_OPENTHREADS_ATOMIC_USE_MUTEX)
mutable Mutex _mutex;
#endif
Should this not be:
#if !defined(_OPENTHREADS_ATOMIC_USE_MUTEX)
mutable Mutex _mutex;
#endif
--
On a different note, The Confg.in is a new one on me, I presume Cmake
generates the actual Config. As a general note I've always kept
header directories so that they only ever contain the actual files
that would be installed, no build related files go in at all. Your
submission breaks this separation. It might be worth moving this
Config.in into another directory to avoid confusion.
--
I'll continue reviewing the changes so that I can get my head around it all.
Robert.
Robert.
More information about the osg-submissions
mailing list