[osg-submissions] osgFX::Cartoon omission

[Robert Osfield]

Hi Vincent,

Now I have the full file I'm able to do a graphical diff and know
exactly what you were addressing.  Indeed this looks to be a debugging
code segment that wasn't removed.  Rather than comment out I've
removed the offending setWidth lines completely and checked the change
in.  Welcome to the world of osg contributors ;-)

I have also changed the constructor so the use LineWidth(2.0) so the
the old 2.0 line width will at least still be their as a default so it
won't change the look unless someone explicitly sets the width.

Cheers,
Robert.

On Wed, Jul 16, 2008 at 3:32 PM, Vincent Bourdier
<vincent.bourdier at gmail.com> wrote:
> Hi Robert,
>
> This is the new file cartoon.cpp in attachement.
>
> This is not a personal preference, but a little change to permit to use the
> Cartoon::setOutlineLineWidth(float w).
> Before modification, it was impossible to obtain a different Line Width, due
> to _wf_lw->setWidth(2); juste before applying it in the StateSet.
> I imagine it was here to test/debug, or just was forgotten...
>
> Deleting/disabling the two instances of "_wf_lw->setWidth(2);" , Line With
> can be changed now.
>
> Regards,
> Vincent
>
> 2008/7/16 Robert Osfield <robert.osfield at gmail.com>:
>>
>> Hi Vincent,
>>
>> Could you send whole files as attachments, rather than suggestions in
>> an email. Further details on the submissions protocol can be found at:
>>
>>
>> http://www.openscenegraph.org/projects/osg/wiki/MailingLists/SubmissionsProtocol
>>
>> As you the change, it does sounds like a personal preference issue
>> rather than a bug, in which case your change might not be suitable.
>> However, I'll need to whole modified file before I can do a full
>> review.
>>
>> Robert.
>>
>>
>> On Wed, Jul 16, 2008 at 2:54 PM, Vincent Bourdier
>> <vincent.bourdier at gmail.com> wrote:
>> > Hi,
>> >
>> > For my first mail in osg Submission I have just a little thing to tell :
>> >
>> > in osgFX/Cartoon.cpp
>> >
>> > Delete :
>> >
>> > 126                 _wf_lw->setWidth(2);
>> >
>> > 242                 _wf_lw->setWidth(2);
>> >
>> > It is just a oversight of the developer for debug I think.
>> > Works better without these lines. (with setLineWidth() )
>> >
>> > Regards,
>> >
>> > Vincent.
>> > _______________________________________________
>> > osg-submissions mailing list
>> > osg-submissions at lists.openscenegraph.org
>> >
>> > http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
>> >
>> >
>> _______________________________________________
>> osg-submissions mailing list
>> osg-submissions at lists.openscenegraph.org
>>
>> http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
>
>
> _______________________________________________
> osg-submissions mailing list
> osg-submissions at lists.openscenegraph.org
> http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
>
>