[osg-submissions] osgFX::Cartoon omission

[Vincent Bourdier]

Hi Robert,

This is the new file cartoon.cpp in attachement.

This is not a personal preference, but a little change to permit to use the
Cartoon::setOutlineLineWidth(float w).
Before modification, it was impossible to obtain a different Line Width, due
to _wf_lw->setWidth(2); juste before applying it in the StateSet.
I imagine it was here to test/debug, or just was forgotten...

Deleting/disabling the two instances of "_wf_lw->setWidth(2);" , Line With
can be changed now.

Regards,
Vincent

2008/7/16 Robert Osfield <robert.osfield at gmail.com>:

> Hi Vincent,
>
> Could you send whole files as attachments, rather than suggestions in
> an email. Further details on the submissions protocol can be found at:
>
>
> http://www.openscenegraph.org/projects/osg/wiki/MailingLists/SubmissionsProtocol
>
> As you the change, it does sounds like a personal preference issue
> rather than a bug, in which case your change might not be suitable.
> However, I'll need to whole modified file before I can do a full
> review.
>
> Robert.
>
>
> On Wed, Jul 16, 2008 at 2:54 PM, Vincent Bourdier
> <vincent.bourdier at gmail.com> wrote:
> > Hi,
> >
> > For my first mail in osg Submission I have just a little thing to tell :
> >
> > in osgFX/Cartoon.cpp
> >
> > Delete :
> >
> > 126                 _wf_lw->setWidth(2);
> >
> > 242                 _wf_lw->setWidth(2);
> >
> > It is just a oversight of the developer for debug I think.
> > Works better without these lines. (with setLineWidth() )
> >
> > Regards,
> >
> > Vincent.
> > _______________________________________________
> > osg-submissions mailing list
> > osg-submissions at lists.openscenegraph.org
> >
> http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
> >
> >
> _______________________________________________
> osg-submissions mailing list
> osg-submissions at lists.openscenegraph.org
>
> http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openscenegraph.org/pipermail/osg-submissions-openscenegraph.org/attachments/20080716/2ea11e37/attachment-0001.htm>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: Cartoon.cpp
URL: <http://lists.openscenegraph.org/pipermail/osg-submissions-openscenegraph.org/attachments/20080716/2ea11e37/attachment-0001.txt>