[osg-submissions] osgPluging pfb -- Mutlitexturing Supported & Segmentation fault fixed

[Robert Osfield]

Hi Anthousis,

Thanks for the smaller set of changes, it's now possible for me to do
a proper review.

A couple of questions, to help clarify things.

  1) Which version of Performer are you compiling against?
  2) Which Performer versions support the multi-texture interface?
  3) What happens what a pfGeoSet doesn't use the multi-texture interface?

My concerns is that we might break the build for other users not using
a modern Performer version, and that the older single texture and more
modern multi-texture interface don't overlap i.e. what happens when a
model has no multi-textures on it.

Robert.


On Wed, Jul 16, 2008 at 10:09 AM, Anthousis Andreadis
<anthousis at gmail.com> wrote:
> Hi Robert,
>
> Sorry for that. I used an indent script i use on my source (i forgot it) and
> you saw the results...
>
> I also checked both the cases i mentioned with svn version and i couldn't
> reproduce the segmentation fault which i originally noticed in 2.2.0
> version. That's the reason i attach only the files for the multitexturing
> support of pfb files.
>
> This time they contain only the changes.
>
> Anthousis
>
> On Tue, Jul 15, 2008 at 6:37 PM, Robert Osfield <robert.osfield at gmail.com>
> wrote:
>>
>> Hi Anthousus,
>>
>> I've just done a graphical diff between your changed files and the
>> ones in SVN trunk, and there are a massive number of changes, most of
>> which seem to surperflous indention/coding style changes.  The extent
>> of these changes means that it very very hard to spot the actual
>> important changes that you have made.  It's just too much of a risk to
>> merge a whole bag of other changes when they don't actual address a
>> problem - the risk is too high on breaking other bits of the code.
>>
>> Could you please explain why you took on yourself to go change so many
>> things, and what bits are the important functional bits of your
>> changes.  Could you also please use the SVN as base for your changes,
>> and apply only changes your need for the functionality you need, once
>> I have this set of changes I can undertake a proper review.
>>
>> Thanks,
>> Robert.
>>
>> On Tue, Jul 15, 2008 at 1:09 PM, Anthousis Andreadis
>> <anthousis at gmail.com> wrote:
>> > Hi
>> >
>> > The 2 problems : osgPlugin::pfb
>> >
>> > 1)
>> > When loading pfb files only the first texture is loaded.
>> > Fixed in-order to check all available texture positions.
>> >
>> >
>> > Result:: support for multitextured pfb files
>> >
>> > 2)
>> > When loading the same .pfb file twice you get a segmentation fault.
>> > I fixed this by replacing the "unrefDelete" command with the performer
>> > command "pfDelete"
>> >
>> >
>> >
>> > The changes have been tested with many pfb models both multitextured and
>> > not.
>> >
>> > Anthousis Andreadis
>> >
>> > _______________________________________________
>> > osg-submissions mailing list
>> > osg-submissions at lists.openscenegraph.org
>> >
>> > http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
>> >
>> >
>> _______________________________________________
>> osg-submissions mailing list
>> osg-submissions at lists.openscenegraph.org
>>
>> http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
>
>
> _______________________________________________
> osg-submissions mailing list
> osg-submissions at lists.openscenegraph.org
> http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
>
>