[osg-submissions] osgPluging pfb -- Mutlitexturing Supported & Segmentation fault fixed

[Robert Osfield]

Hi Anthousus,

I've just done a graphical diff between your changed files and the
ones in SVN trunk, and there are a massive number of changes, most of
which seem to surperflous indention/coding style changes.  The extent
of these changes means that it very very hard to spot the actual
important changes that you have made.  It's just too much of a risk to
merge a whole bag of other changes when they don't actual address a
problem - the risk is too high on breaking other bits of the code.

Could you please explain why you took on yourself to go change so many
things, and what bits are the important functional bits of your
changes.  Could you also please use the SVN as base for your changes,
and apply only changes your need for the functionality you need, once
I have this set of changes I can undertake a proper review.

Thanks,
Robert.

On Tue, Jul 15, 2008 at 1:09 PM, Anthousis Andreadis
<anthousis at gmail.com> wrote:
> Hi
>
> The 2 problems : osgPlugin::pfb
>
> 1)
> When loading pfb files only the first texture is loaded.
> Fixed in-order to check all available texture positions.
>
>
> Result:: support for multitextured pfb files
>
> 2)
> When loading the same .pfb file twice you get a segmentation fault.
> I fixed this by replacing the "unrefDelete" command with the performer
> command "pfDelete"
>
>
>
> The changes have been tested with many pfb models both multitextured and
> not.
>
> Anthousis Andreadis
>
> _______________________________________________
> osg-submissions mailing list
> osg-submissions at lists.openscenegraph.org
> http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
>
>