[osg-submissions] OpenFlight reader now allows files with no hierarchy.

Robert Osfield robert.osfield at gmail.com
Fri Jul 11 10:16:55 PDT 2008


Hi Joakim,

I have merged most of your change, and done it two batches - first I
checked in the typo fixes, then I checked in your changes to Opcodes.h
and ReaderWriterFLT.cpp.

I haven't checked in the changes of opcode_type to Opcodes, instead
leaving the type as int.  I do this as it's not clear to me the value
in doing this change.  It's worth noting there has been discussion on
this list about what type is actual meant according to the spec and
encountered files.  I don't have any answer to this, but it'd be good
to settle this before going for something different than what is there
already.

Robert.

On Fri, Jul 4, 2008 at 2:22 PM, Joakim Simonsson <joakim at autosim.no> wrote:
>
> RecordInputStream.h:
> * The typedef "opcode_type" is no longer an int. It is changed to the enum
> "Opcodes".
>
> Opcodes.h:
> * Added INVALID_OP as -1 in the Opcodes enum. Note that INVALID_OP is not an
> actual opcode defined in the OpenFlight format. The purpose of INVALID_OP is
> to mark an opcode variable as invalid or uninitialized.
>
> ReaderWriterFLT.cpp:
> * The header node is returned if it exists, even if the file does not
> contain a node hierarchy. The old behaviour returned a ERROR_IN_READING_FILE
> error.
> * Changed opcodes initialized to -1 to the new enum value INVALID_OP.
>
> AncillaryRecords.cpp:
> Document.cpp:
> Document.h:
> expAncillaryRecords.cpp:
> expGeometryRecords.cpp:
> ExportOptions.cpp:
> expPrimaryRecords.cpp:
> FltExportVisitor.cpp:
> PaletteRecords.cpp:
> Pools.h:
> PrimaryRecords.cpp:
> RecordInputStream.cpp:
> VertexPaletteManager.cpp:
> VertexRecords.cpp:
> Document.h:
> * Typos fixed.
>
>
> --
> Joakim Simonsson
> _______________________________________________
> osg-submissions mailing list
> osg-submissions at lists.openscenegraph.org
> http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
>
>


More information about the osg-submissions mailing list