[osg-submissions] ClipPlane Unitialized Variable

Robert Osfield robert.osfield at gmail.com
Fri Jan 18 12:18:27 PST 2008


Hi Jeremy,

I've review your change but have decided to go with setting the
_clipPlaneNum to the value passed into the constructor directly rather
than setting it to 0, then calling setClipPlaneNum().

The end result should be the same, hopefully... :-)

Robert.

On Jan 16, 2008 8:15 PM, Jeremy Moles <jeremy at emperorlinux.com> wrote:
> Attached is a version of the ClipPlane header that initializes
> _clipPlaneNum to 0 before calling setClipPlaneNum() in the various
> constructors. This is necessary because even though we're setting the
> clipPlaneNum with the call to setClipPlanNum(), the function actually
> checks the current value first, which is uninitialized.
>
> I found this while running valgrind, and will probably be submitting a
> few more the next few days.
>
> (The diff is just for your own cursory glance)
>
> _______________________________________________
> osg-submissions mailing list
> osg-submissions at lists.openscenegraph.org
> http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
>
>


More information about the osg-submissions mailing list