[osg-submissions] Group::removeChildren fix

[Garrett Potts]

Hello All:

Is there a problem with childRemoved taking as an argument a  
osg::Node* type.  Looking at the code in where childRemoved in the  
osg::Group node the indices as mentioned can't really be used to  
access the list in which the node was removed.  Instead, would it be  
better to just pass the osg::Node* to childRemoved?


virtual void childRemoved(osg::Node* node)


Take care

Garrett

On Jan 14, 2008, at 12:28 PM, Robert Osfield wrote:

> HI Daniel,
>
> On Jan 14, 2008 4:55 PM, Daniel Stien <daniel at stien.org> wrote:
>> childRemoved() didn't seem to serve any purpose if there was no way  
>> to
>> determine which children were affected. You're right, if  
>> childRemoved()
>> is supposed to be fed an index position in _children it should  
>> probably
>> be given a more suitable name. What about childRemoving()?
>
> I disagree, childRemoved says.. the child has been removed, its say
> exactly what has happend.
>
>> I'm subclassing Group to encapsulate a third party collision/dynamics
>> world,
>> using childInserted()/childRemoved() to internally add/remove rigid  
>> body
>> nodes.
>
> Thanks for the clarification.
>
> Robert.
> _______________________________________________
> osg-submissions mailing list
> osg-submissions at lists.openscenegraph.org
> http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org