[osg-submissions] Move MRT into FBO patch

[Robert Osfield]

Hi Art,

I've begun reviewing your changes and spotted a threading issue in
FrameBufferObject::apply() relating to the population of the _drawBuffers
vector.  I'm inclined to think that this vector might be best managed as a
temporary that is created and applied when required.  Doing this would mean
that some code in RenderStage would need to change.

I am generally positive about these changes though - moving the setup into
FrameBufferObject does look to be a cleaner way of tackling the task rather
using RenderStage code to do it.

Robert.

On Tue, Apr 15, 2008 at 3:19 PM, Art Tevs <stud_info2 at yahoo.de> wrote:

> Hi Robert,
>
> as from our discussion previously here is now the
> patch which do move the MRT functionality out of
> osgUtil::RenderStage in to osg::FrameBufferObject.
>
> ---------------------------------------------------
> DESCRIPTIUON:
> Each FBO does now manages a list of all color
> attachments , which are setted as rendering targets
> with glDrawBuffers call when the FBO is applied.
>
> This is neccessary to allow the use of FBOs without
> camera objects as it was done previously.
>
>
> TESTING:
> Tested with osg examples and with my own. The
> applications seems to work properly.
> osgmultiplerenderingtarget example do also its job
> without any problems.
> -----------------------------------------------------
>
> I would like to have this patch included before v2.4,
> since this do enables more general use of MRTs in osg.
>
> It would be also very gladious if the author of the
> previous implementation could check the new
> functionality with his own software.
>
>
> Best regards,
> Art
>
>
>
>
>
>      __________________________________________________________
> Gesendet von Yahoo! Mail.
> Der Lieblings-Mailbox der Welt.
> http://de.overview.mail.yahoo.com
>
> _______________________________________________
> osg-submissions mailing list
> osg-submissions at lists.openscenegraph.org
>
> http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.openscenegraph.org/pipermail/osg-submissions-openscenegraph.org/attachments/20080415/b1c2d298/attachment.htm