[osg-submissions] Fixing osgTerrain::Layer::getFileName problem with osgDotNet

[Mike Wittman]

Hi Robert,

 

Testing with 2.1.9 I found that the reference return of
osgTerrain::Layer::getFileName and its overrides is causing a problem
with osgDotNet.  In general, reference returns from virtual functions
are difficult to handle in the wrappers because data conversions between
.NET and C++ objects are performed with temporary objects.

 

Would you mind changing the return value to just std::string to avoid
the problem, per the attached file?  (I'd argue this change also makes
sense from a strictly C++ perspective, as a const std::string& return
value forces subclasses to maintain a std::string value internally when
it might not otherwise be necessary.)

 

 

Mike Wittman

mwittman at seismicmicro.com <mailto:mwittman at seismicmicro.com> 

___________________________________________________

Seismic Micro-Technology, Inc.

8584 Katy Freeway, Suite 400 / Houston, Texas 77024

Tel.  +1 (713) 464-6188

Fax. +1 (713) 464-6440

Web:  www.seismicmicro.com
<blocked::blocked::http://www.seismicmicro.com> 

___________________________________________________

Seismic through Simulation with KINGDOM, (RC)2, and SURE! - CONTACT US
TODAY for more information.

 

 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.openscenegraph.org/pipermail/osg-submissions-openscenegraph.org/attachments/20070905/63020b9a/attachment.htm 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: Layer
Type: application/octet-stream
Size: 11887 bytes
Desc: Layer
Url : http://lists.openscenegraph.org/pipermail/osg-submissions-openscenegraph.org/attachments/20070905/63020b9a/attachment-0001.obj