[osg-submissions] Fix to StateSet::merge

[Paul Martz]

Ha ha. This is funny.

I actually coded my own fix for this, then got distracted by another
unrelated project. Not only did I forget to submit my fix, I forgot that I
coded it entirely.

Thanks Mario (and thanks for the tweaking my memory, Andy).
   -Paul
 

-----Original Message-----
From: osg-submissions-bounces at lists.openscenegraph.org
[mailto:osg-submissions-bounces at lists.openscenegraph.org] On Behalf Of Andy
Skinner
Sent: Wednesday, November 14, 2007 5:57 PM
To: OpenSceneGraph Submissions
Subject: Re: [osg-submissions] Fix to StateSet::merge

Part of the reason Mario made this change was that it agree with a post from
you:
http://article.gmane.org/gmane.comp.graphics.openscenegraph.user/17087/m
atch=merge
Did you get a response?  What did you do to get past it?

Mario found that when we have an OVERRIDE attribute with a PROTECTED
attribute deeper in the tree, the OVERRIDE won out over the PROTECTED one.
That isn't supposed to happen, is it?  The behavior that Mario implemented
was what we saw in other parts of the OSG code.  How did this work out in
your own code?

thanks,
andy


-----Original Message-----
From: osg-submissions-bounces at lists.openscenegraph.org
[mailto:osg-submissions-bounces at lists.openscenegraph.org] On Behalf Of Paul
Martz
Sent: Wednesday, November 14, 2007 7:06 PM
To: 'OpenSceneGraph Submissions'
Subject: Re: [osg-submissions] Fix to StateSet::merge

> Currently, in the StateSet::merge method, the rhs state attributes and 
> modes are not merged into the lhs state when the rhs is PROTECTED. The 
> changes I'm providing here address this problem.

I have a NodeVisitor that tracks current state as it walks the scene graph.
(I believe) it currently handles inheritance correctly. I'm conerned that
this change would break that.

Does your change fix an issue you've encountered, and if so, what?
   -Paul

_______________________________________________
osg-submissions mailing list
osg-submissions at lists.openscenegraph.org
http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegr
aph.org
_______________________________________________
osg-submissions mailing list
osg-submissions at lists.openscenegraph.org
http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.
org