[osg-submissions] OSG 2.1.5 fixes for MINGW
Robert Osfield
robert.osfield at gmail.com
Sun Aug 19 12:04:56 PDT 2007
HI Antoine,
On 8/19/07, Antoine Hue <tonio_73 at tiscali.fr> wrote:
> - 1- osgShadow uint
> osgShadow has an undefined type "uint". I have typedefed GLuint to uint
> to work this around.
This was fixed last Monday, so already checked in.
> - 2- osgPlugins/txp compiling
> TXP plugin is not compiling (nor on OSG 2.0.0). The issue is coming from
> a missing "-I." argument to gcc. I do not get it why is works under Linux.
> Anyway, root issue is that includes are not correctly written: all use
> <> includes even for local files. I have fixed this since I could not
> fix the compiler command (thanks sed) : attached but untested (only
> compiling and linking).
I think the right way to solve this one is to add the include of the
local directory into the build rather than change the <> to "". The
code you've changed is provided by Terrex and the next code drop they
provide will have the <> in it and therefore break the build once
more. This should just require a tweak of the txp/CMakeLists.txt
file.
> -3- osgDB/Registry.cpp looking for libosgPlugins-2.1.5/osgdb_xxx.dll
>
> osgDB/Registry.cpp has a bug when looking for a std plugin: lib prefix
> is inserted before osgplugins/ : attached.
Thanks now merged and submitted to SVN. I also fixed the Cygwin path
as it had a similar problem. I do think that both paths are still
wrong though - the plugins shouldn't have a cyn or lib prefix really,
they are plugins, they should just be compiled as osgdb_ext.lib/.dll.
Cygwin and Mingw contributors have in the past have chosen the
different naming, I don't know the original motivation though nor
whether it still applies to today.
> -4- Plugins install
>
> Plugins install is wrong: they are copied to the bin directory instead
> of bin/osgPlugins-2.1.5.
>
> No fix provided (manual fix on my machine).
This is another Win32/Mingw specific issue, a tweak to the
CMakeModules files are all that should be required. I don't know off
hand which bit to tweak though.
> I have compiled VirtualPlanetBuilder-0.9.1 sucessfully and it works fine.
Great to hear, thanks for the feedback.
More information about the osg-submissions
mailing list