[osg-submissions] fix for osgViewer auto-repeat behavior in X11

[Tim Moore]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Robert Osfield wrote:
> Hi Tim,
> 
> On 8/5/07, Tim Moore <timoore at redhat.com> wrote:
>> Was there anything controversial in this fix for GraphicsWindowX11 autorepeat
>> behavior? This is an important fix for the FlightGear project and hard to
>> work around without a patch to Open Scene Graph.
> 
> Sorry for the delay, just been lots on my plate this last week.
> Submission now reviewed, merged with the addition of #if 1 #endif
> around the block of code in question, and checked into SVN.
> 
Thanks for checking it in! I didn't want to be a pain, but didn't want it to slip
through the cracks either.

> I understand what the code is after and how it does it, but I am
> concerned that it'll not be 100% robust, and that occasionally there
> will be a release while the next key repeat event is has not be
> delivered into the event queue.  However, my guess this would be a
> very very rare occurrence given that X11 probably sends both events
> right after each other and from the same thread.  Failure will also be
> pretty benign, the worst that happens is that a key release is made
> that isn't intended.  I can't image much user code collapsing because
> of it... :-)
That's my understanding too, though I haven't examined the X server source code.

Tim

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org

iD8DBQFGtgOIeDhWHdXrDRURAgESAJ9PRKnmGsotiRT4q71nuv2WQeOlxQCgnF/q
Q3VK/uNOM4+kpko5qZyq3AU=
=ub+d
-----END PGP SIGNATURE-----