[osg-submissions] fix for osgViewer auto-repeat behavior in X11
Robert Osfield
robert.osfield at gmail.com
Sun Aug 5 07:45:26 PDT 2007
Hi Tim,
On 8/5/07, Tim Moore <timoore at redhat.com> wrote:
> Was there anything controversial in this fix for GraphicsWindowX11 autorepeat
> behavior? This is an important fix for the FlightGear project and hard to
> work around without a patch to Open Scene Graph.
Sorry for the delay, just been lots on my plate this last week.
Submission now reviewed, merged with the addition of #if 1 #endif
around the block of code in question, and checked into SVN.
I understand what the code is after and how it does it, but I am
concerned that it'll not be 100% robust, and that occasionally there
will be a release while the next key repeat event is has not be
delivered into the event queue. However, my guess this would be a
very very rare occurrence given that X11 probably sends both events
right after each other and from the same thread. Failure will also be
pretty benign, the worst that happens is that a key release is made
that isn't intended. I can't image much user code collapsing because
of it... :-)
Robert.
More information about the osg-submissions
mailing list