[osg-users] Two warnings in osgWidgets (opps!)

Jeremy Moles jeremy at emperorlinux.com
Thu Jul 17 06:54:43 PDT 2008


On Thu, 2008-07-17 at 14:22 +0100, Robert Osfield wrote:
> Hi Justin,
> 
> I will wait for Jeremy to make a decision on what he wants to do about
> this warning as just changing types to fix a warning may well loose
> something elsewhere.

Yeah, making these ints should be fine. We won't be able to use 0, since
that's a valid index in some cases. I've tested this quickly and it
doesn't appear to cause any problems...

> Robert.
> 
> On Thu, Jul 17, 2008 at 2:05 PM, Vican, Justin E. <jvican at draper.com> wrote:
> > Hi All,
> > I get the same warnings (64Bit Linux, RHEL 4, gcc3.4.6).
> > -Justin
> >
> > -----Original Message-----
> > From: osg-users-bounces at lists.openscenegraph.org
> > [mailto:osg-users-bounces at lists.openscenegraph.org] On Behalf Of Mario
> > Valle
> > Sent: Thursday, July 17, 2008 3:12 AM
> > To: osg-users at lists.openscenegraph.org
> > Subject: [osg-users] Two warnings in osgWidgets (opps!)
> >
> >
> >  From this morning SVN on AMD 64 bits:
> >
> > /users/mvalle/OSG/OpenSceneGraph/src/osgWidget/Window.cpp: In member
> > function `void
> > osgWidget::Window::_removeFromGeode(osgWidget::Widget*)':
> > /users/mvalle/OSG/OpenSceneGraph/src/osgWidget/Window.cpp:413: warning:
> > converting of
> > negative value `-0x00000000000000001' to `unsigned int'
> > /users/mvalle/OSG/OpenSceneGraph/src/osgWidget/WindowManager.cpp: In
> > member function
> > `virtual void osgWidget::WindowManager::childRemoved(unsigned int,
> > unsigned int)':
> > /users/mvalle/OSG/OpenSceneGraph/src/osgWidget/WindowManager.cpp:275:
> > warning: converting
> > of negative value `-0x00000000000000001' to `unsigned int'
> >
> >
> > The quickest fix is to change the type of _index in
> > include/osgWidgets/Window line 406 and
> > include/osgWidget/Widget line 440 to int.
> >
> > But from a quick look at the code I think setting _index to 0 instead of
> > -1 is safe in
> > those two places.
> >
> > Could you look at this?
> > Ciao!
> >                mario
> >
> > --
> > Ing. Mario Valle
> > Data Analysis and Visualization Services         |
> > http://www.cscs.ch/~mvalle
> > Swiss National Supercomputing Centre (CSCS)      | Tel:  +41 (91)
> > 610.82.60
> > v. Cantonale Galleria 2, 6928 Manno, Switzerland | Fax:  +41 (91)
> > 610.82.82
> >
> > _______________________________________________
> > osg-users mailing list
> > osg-users at lists.openscenegraph.org
> > http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.or
> > g
> > _______________________________________________
> > osg-users mailing list
> > osg-users at lists.openscenegraph.org
> > http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org
> >
> _______________________________________________
> osg-users mailing list
> osg-users at lists.openscenegraph.org
> http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org
> 




More information about the osg-users mailing list