[osg-users] KdTree support now checked in

Robert Osfield robert.osfield at gmail.com
Sat Jul 12 03:47:07 PDT 2008


Hi Adrian,

Thanks for the note,  the code that is generating the warning is just
experimental code, it's served it's purpose and now can be removed.
An svn update will get this clean up.

Robert.

On Sat, Jul 12, 2008 at 8:37 AM, Adrian Egli OpenSceneGraph (3D)
<3dhelp at gmail.com> wrote:
> Hi Robert
> Compiling...ends in some warnings, may you can fix them
>
> KdTree.cpp(108) : warning C4018: '<=' : signed/unsigned mismatch
>
> osgkdtree.cpp
> c:\dev\OpenSceneGraphSVN\Openscenegraph\examples\osgkdtree\fixeddivision.h(115)
> : warning C4018: '>' : signed/unsigned mismatch
> c:\dev\OpenSceneGraphSVN\Openscenegraph\examples\osgkdtree\fixeddivision.h(128)
> : warning C4018: '>' : signed/unsigned mismatch
> c:\dev\OpenSceneGraphSVN\Openscenegraph\examples\osgkdtree\fixeddivision.h(145)
> : warning C4018: '>' : signed/unsigned mismatch
> c:\dev\OpenSceneGraphSVN\Openscenegraph\examples\osgkdtree\fixeddivision.h(159)
> : warning C4018: '>' : signed/unsigned mismatch
> c:\dev\OpenSceneGraphSVN\Openscenegraph\examples\osgkdtree\fixeddivision.h(177)
> : warning C4018: '>' : signed/unsigned mismatch
> c:\dev\OpenSceneGraphSVN\Openscenegraph\examples\osgkdtree\fixeddivision.h(261)
> : warning C4018: '<' : signed/unsigned mismatch
> c:\dev\OpenSceneGraphSVN\Openscenegraph\examples\osgkdtree\variabledivision.h(130)
> : warning C4018: '>' : signed/unsigned mismatch
> c:\dev\OpenSceneGraphSVN\Openscenegraph\examples\osgkdtree\variabledivision.h(143)
> : warning C4018: '>' : signed/unsigned mismatch
> c:\dev\OpenSceneGraphSVN\Openscenegraph\examples\osgkdtree\variabledivision.h(161)
> : warning C4018: '>' : signed/unsigned mismatch
> variabledivision.cpp
> c:\dev\OpenSceneGraphSVN\Openscenegraph\examples\osgkdtree\variabledivision.h(130)
> : warning C4018: '>' : signed/unsigned mismatch
> c:\dev\OpenSceneGraphSVN\Openscenegraph\examples\osgkdtree\variabledivision.h(143)
> : warning C4018: '>' : signed/unsigned mismatch
> c:\dev\OpenSceneGraphSVN\Openscenegraph\examples\osgkdtree\variabledivision.h(161)
> : warning C4018: '>' : signed/unsigned mismatch
> variabledivision.cpp(194) : warning C4018: '<=' : signed/unsigned mismatch
> fixeddivision.cpp
> c:\dev\OpenSceneGraphSVN\Openscenegraph\examples\osgkdtree\fixeddivision.h(115)
> : warning C4018: '>' : signed/unsigned mismatch
> c:\dev\OpenSceneGraphSVN\Openscenegraph\examples\osgkdtree\fixeddivision.h(128)
> : warning C4018: '>' : signed/unsigned mismatch
> c:\dev\OpenSceneGraphSVN\Openscenegraph\examples\osgkdtree\fixeddivision.h(145)
> : warning C4018: '>' : signed/unsigned mismatch
> c:\dev\OpenSceneGraphSVN\Openscenegraph\examples\osgkdtree\fixeddivision.h(159)
> : warning C4018: '>' : signed/unsigned mismatch
> c:\dev\OpenSceneGraphSVN\Openscenegraph\examples\osgkdtree\fixeddivision.h(177)
> : warning C4018: '>' : signed/unsigned mismatch
> c:\dev\OpenSceneGraphSVN\Openscenegraph\examples\osgkdtree\fixeddivision.h(261)
> : warning C4018: '<' : signed/unsigned mismatch
> fixeddivision.cpp(256) : warning C4018: '<' : signed/unsigned mismatch
> fixeddivision.cpp(378) : warning C4018: '<=' : signed/unsigned mismatch
> Generating Code...
> Linking...
>
>
> 2008/7/12 Adrian Egli OpenSceneGraph (3D) <3dhelp at gmail.com>:
>>
>> Hi Robert
>>
>> Perfect, i will help you in analyzing the performance bottle neck. of
>> course the kd-tree will be an imporant new feature, and also new rendering
>> technics could become reasonable once we have a really fast framework for
>> intersection tests.
>>
>> /adrian
>>
>>
>> 2008/7/12 Jean-Sébastien Guay <jean-sebastien.guay at cm-labs.com>:
>>>
>>> Hi Robert,
>>>
>>>> To wrap, all these changes on now in SVN trunk and will be part of
>>>> 2.5.4 and hence the up coming 2.6.  If you enable the build of
>>>> automatic KdTrees of load and use
>>>> IntersectionVisitor/LineSegmentIntersector then you'll be able to go
>>>> straight ahead of use KdTree intersections without lifting a further
>>>> finger ;-)
>>>
>>> This is all very cool! I'll definitely be testing this out in the next
>>> few days to try it out with my Masters project (which was very
>>> intersection-heavy). I'll be setting up a little competition between your
>>> KdTree and Adrian Egli's... Just kidding!
>>>
>>> I think I may be able to help a bit regarding the higher-level setup and
>>> bookkeeping changes needed to speed things up on that regard. One thing I
>>> noticed before is that creating a new Intersector and IntersectionVisitor
>>> each time is costly, and instead keeping static or cached instances and
>>> using the reset() and setStart()/setEnd() methods is faster. There may be
>>> some other similar things that can be done too, we'll see what I can dig up.
>>>
>>> Thanks a lot for this work, it's a great addition, and I expect that it
>>> will be useful in lots of different applications.
>>>
>>> J-S
>>> --
>>> ______________________________________________________
>>> Jean-Sebastien Guay    jean-sebastien.guay at cm-labs.com
>>>                               http://www.cm-labs.com/
>>>                        http://whitestar02.webhop.org/
>>> _______________________________________________
>>> osg-users mailing list
>>> osg-users at lists.openscenegraph.org
>>> http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org
>>
>>
>>
>> --
>> ********************************************
>> Adrian Egli
>
>
> --
> ********************************************
> Adrian Egli
> _______________________________________________
> osg-users mailing list
> osg-users at lists.openscenegraph.org
> http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org
>
>



More information about the osg-users mailing list